Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sanity (pep8) issues #213

Closed
wants to merge 5 commits into from
Closed

Fix sanity (pep8) issues #213

wants to merge 5 commits into from

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 14, 2023

SUMMARY

Replace type(foo) == bar with isinstance(foo, bar)

ISSUE TYPE
  • Misc Pull Request

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/85513872b9e844339424292c7d0774e6

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 8m 43s
❌ ansible-test-network-integration-asa-python39 RETRY_LIMIT in 9m 48s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable212 RETRY_LIMIT in 9m 14s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable214 FAILURE in 8m 55s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable211 FAILURE in 8m 57s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable29 FAILURE in 8m 23s (non-voting)
❌ ansible-test-network-integration-asa-libssh-python39 RETRY_LIMIT in 5m 36s
✔️ ansible-test-network-integration-asa-libssh-python38-stable214 SUCCESS in 12m 43s
✔️ ansible-test-network-integration-asa-libssh-python38-stable212 SUCCESS in 12m 18s
✔️ ansible-test-network-integration-asa-libssh-python38-stable211 SUCCESS in 12m 12s
❌ ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 12m 14s (non-voting)
✔️ ansible-changelog-fragment SUCCESS in 14s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 48s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 36s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 14m 27s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 14m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 38s
✔️ ansible-test-units-asa-python39 SUCCESS in 6m 50s
✔️ ansible-test-units-asa-python36 SUCCESS in 7m 40s
✔️ ansible-test-units-asa-python37 SUCCESS in 6m 44s
✔️ ansible-tox-linters SUCCESS in 10m 35s

@rohitthakur2590
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9097e0b68a324545b61edc30967d4bcc

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 8m 37s
❌ ansible-test-network-integration-asa-python39 RETRY_LIMIT in 9m 20s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable212 FAILURE in 7m 22s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable214 FAILURE in 7m 17s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable211 FAILURE in 7m 21s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable29 FAILURE in 8m 29s (non-voting)
❌ ansible-test-network-integration-asa-libssh-python39 RETRY_LIMIT in 9m 34s
✔️ ansible-test-network-integration-asa-libssh-python38-stable214 SUCCESS in 12m 53s
✔️ ansible-test-network-integration-asa-libssh-python38-stable212 SUCCESS in 12m 32s
✔️ ansible-test-network-integration-asa-libssh-python38-stable211 SUCCESS in 12m 12s
❌ ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 12m 35s (non-voting)
✔️ ansible-changelog-fragment SUCCESS in 14s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 12s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 51s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 11m 53s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 08s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 09s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 06s
✔️ ansible-test-units-asa-python39 SUCCESS in 7m 25s
✔️ ansible-test-units-asa-python36 SUCCESS in 7m 45s
✔️ ansible-test-units-asa-python37 SUCCESS in 8m 22s
✔️ ansible-tox-linters SUCCESS in 10m 26s

@rohitthakur2590
Copy link
Contributor

already fixed by: #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitthakur2590 rohitthakur2590 rohitthakur2590 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qalthos @rohitthakur2590